Re: [whatwg/fetch] Add potential destination. (#547)

annevk commented on this pull request.



> @@ -1468,7 +1469,6 @@ for each associated <a for="fetch group">fetch record</a> whose
 <a for="fetch group">fetch record</a>'s
 <a for="fetch record">fetch</a> with reason <i>fatal</i>.
 
-

Unintentional?

> @@ -1427,6 +1413,21 @@ is a <a>filtered response</a> whose
  <li><p>Return <var>newResponse</var>.
 </ol>
 
+<h4 id=miscellaneous>Miscellaneous</h4>
+
+<p>A <dfn export id=concept-potential-destination>potential destination</dfn> is "<code>fetch</code>" or a <a for=request>destination</a>.

This seems longer than 100 columns.

> @@ -1427,6 +1413,21 @@ is a <a>filtered response</a> whose
  <li><p>Return <var>newResponse</var>.
 </ol>
 
+<h4 id=miscellaneous>Miscellaneous</h4>
+
+<p>A <dfn export id=concept-potential-destination>potential destination</dfn> is "<code>fetch</code>" or a <a for=request>destination</a>.
+
+<p>To <dfn export for=destination id=concept-potential-destination-translate>translate</dfn> a
+<a for=/>potential destination</a> <code>potentialDestination</code>, run these steps:

Variables use `<var>`, not `<code>`.

> @@ -1427,6 +1413,21 @@ is a <a>filtered response</a> whose
  <li><p>Return <var>newResponse</var>.
 </ol>
 
+<h4 id=miscellaneous>Miscellaneous</h4>
+
+<p>A <dfn export id=concept-potential-destination>potential destination</dfn> is "<code>fetch</code>" or a <a for=request>destination</a>.
+
+<p>To <dfn export for=destination id=concept-potential-destination-translate>translate</dfn> a
+<a for=/>potential destination</a> <code>potentialDestination</code>, run these steps:
+
+<ol>
+ <li><p>If <code>potentialDestination</code> is "<code>fetch</code>", then return the empty string.
+
+ <li><p>Assert: <code>potentialDestination</code> is a <a for=request>destination</a>.
+
+ <li><p>Return <code>potentialDestination</code>.
+

This newline can be removed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/547#pullrequestreview-39717080