Re: [whatwg/fetch] Add potential destination. (#547)

annevk requested changes on this pull request.



> @@ -810,6 +810,20 @@ the empty string,
 "<code>worker</code>", or
 "<code>xslt</code>". Unless stated otherwise it is the empty string.
 
+<p>A <dfn export id=concept-potential-destination>potential destination</dfn> is "<code>fetch</code>" or a <a for=request>destination</a>.

If we do  this we should probably also abstract "destination" as currently it belongs to a request. Maybe that's more trouble than it's worth though. Hmm.

> @@ -810,6 +810,20 @@ the empty string,
 "<code>worker</code>", or
 "<code>xslt</code>". Unless stated otherwise it is the empty string.
 
+<p>A <dfn export id=concept-potential-destination>potential destination</dfn> is "<code>fetch</code>" or a <a for=request>destination</a>.
+
+<p>To <dfn export for=destination id=concept-potential-destination-translate>translate</dfn> a
+<a for=/>potential destination</a> into a <a for=request>destination</a>, run these steps:

"To translate a potential destination _potentialDestination_, run these steps:"

Variables need to be introduced and we usually don't specify the return value.

> @@ -810,6 +810,20 @@ the empty string,
 "<code>worker</code>", or
 "<code>xslt</code>". Unless stated otherwise it is the empty string.
 
+<p>A <dfn export id=concept-potential-destination>potential destination</dfn> is "<code>fetch</code>" or a <a for=request>destination</a>.
+
+<p>To <dfn export for=destination id=concept-potential-destination-translate>translate</dfn> a
+<a for=/>potential destination</a> into a <a for=request>destination</a>, run these steps:
+
+<ol>
+ <li><p>If <a for=/>potential destination</a> is "<code>fetch</code>", return the empty string.
+
+ <li><p>Assert: <a for=/>potential destination</a> is a valid <a for=request>destination</a>.
+
+ <li><p>If <a for=/>potential destination</a> is a valid <a for=request>destination</a>, return its value.

We already know it's a destination due to the assert. Just return it here.

> @@ -810,6 +810,20 @@ the empty string,
 "<code>worker</code>", or
 "<code>xslt</code>". Unless stated otherwise it is the empty string.
 
+<p>A <dfn export id=concept-potential-destination>potential destination</dfn> is "<code>fetch</code>" or a <a for=request>destination</a>.
+
+<p>To <dfn export for=destination id=concept-potential-destination-translate>translate</dfn> a
+<a for=/>potential destination</a> into a <a for=request>destination</a>, run these steps:
+
+<ol>
+ <li><p>If <a for=/>potential destination</a> is "<code>fetch</code>", return the empty string.
+
+ <li><p>Assert: <a for=/>potential destination</a> is a valid <a for=request>destination</a>.

No need to say valid.

> @@ -810,6 +810,20 @@ the empty string,
 "<code>worker</code>", or
 "<code>xslt</code>". Unless stated otherwise it is the empty string.
 
+<p>A <dfn export id=concept-potential-destination>potential destination</dfn> is "<code>fetch</code>" or a <a for=request>destination</a>.
+
+<p>To <dfn export for=destination id=concept-potential-destination-translate>translate</dfn> a
+<a for=/>potential destination</a> into a <a for=request>destination</a>, run these steps:
+
+<ol>
+ <li><p>If <a for=/>potential destination</a> is "<code>fetch</code>", return the empty string.

then return*

> @@ -810,6 +810,20 @@ the empty string,
 "<code>worker</code>", or
 "<code>xslt</code>". Unless stated otherwise it is the empty string.
 
+<p>A <dfn export id=concept-potential-destination>potential destination</dfn> is "<code>fetch</code>" or a <a for=request>destination</a>.

We should also move this to its own section. Maybe just a new section after "Responses" called "Miscellaneous"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/547#pullrequestreview-39693384