Re: [whatwg/url] Record whether the URL parser removed newlines. (#284)

> I guess it might not be completely catastrophic to add some code in all the unlikely cases of branches if a tab or newline is hit.

What does WebKit's implementation of newline removal look like now? Do y'all just farm out to NSURL?

> I'm also concerned about adding another bool to a URL object which ought to remain simple and small, but maybe the slippery slope argument won't be enough to stop this.

As written here, the flag isn't exposed to the web (except implicitly via the Fetch behavior, as @annevk notes). I agree that it doesn't seem necessary to add a `bool` to the `URL` interface.

> I also think it's a bad idea to put something that blocks content that looks like an attack into the fetch spec, but that's an argument to be had there.

Happy to have that discussion on the other patch: https://github.com/whatwg/fetch/pull/519. Given that we're already doing things like https://fetch.spec.whatwg.org/#should-response-to-request-be-blocked-due-to-mime-type? there, this doesn't seem like much of a stretch, but I'm interested in hearing about possible alternatives.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/284#issuecomment-303322624