- From: Xidorn Quan <notifications@github.com>
- Date: Mon, 22 May 2017 21:11:37 -0700
- To: whatwg/fullscreen <fullscreen@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fullscreen/pull/91/c303285510@github.com>
Sadly, Gecko still doesn't have `dialog`... so this is not applicable. I don't recall exactly what the problems are for that... It seems one of the problem would be that `showModal` may be called on a dialog element which is already a fullscreen element? For that, I would probably prefer the second way, specifically, we pop out fullscreen elements until the dialog is no longer a fullscreen element, and then we add the element back as a dialog. But thinking about this a bit further, this option is probably unnecessarily complicated, because that means we would need to consider dispatching event, and even unfullscreen the window, for a `showModal` call, which sounds unfortunate. Given this, I guess we should make HTML avoid invoking top-layer-add when the element is already a fullscreen element by rejecting it with a exception, and I think we should assert in top-layer-add that the element to be append is not currently an element in the top layer. If we add that assertion, we would also need to think about what if a modal dialog requests fullscreen. Maybe we should reject as well. I don't think those cases are common, and I don't have idea how authors may find those cases useful... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fullscreen/pull/91#issuecomment-303285510
Received on Tuesday, 23 May 2017 04:12:12 UTC