Re: [whatwg/url] Clearly indicate a known issue with ToASCII (#309)

TimothyGu commented on this pull request.



> @@ -280,10 +280,14 @@ U+005C (\), or U+005D (]).
 <a>domain</a> <var>domain</var>, runs these steps:
 
 <ol>
- <li><p>Let <var>result</var> be the result of running <a abstract-op lt=ToASCII>Unicode ToASCII</a> with
- <i>domain_name</i> set to <var>domain</var>, <i>UseSTD3ASCIIRules</i> set to false,
- <i>processing_option</i> set to <i>Nontransitional_Processing</i>, and <i>VerifyDnsLength</i> set
- to false.
+ <li>
+  <p>Let <var>result</var> be the result of running <a abstract-op lt=ToASCII>Unicode ToASCII</a>
+  with <i>domain_name</i> set to <var>domain</var>, <i>UseSTD3ASCIIRules</i> set to false,
+  <i>CheckHyphens</i> set to false, <i>processing_option</i> set to
+  <i>Nontransitional_Processing</i>, and <i>VerifyDnsLength</i> set to false.

Hmm we technically need to specify *CheckBidi* and *CheckJoiners* too since the spec doesn't offer any default values for those.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/309#pullrequestreview-39327827