Re: [whatwg/fetch] WIP: Cancelation (#523)

annevk requested changes on this pull request.

Other things I wonder about:

* How does this relate to any stream activity and how does that fall out of "terminate a fetch".
* Do we need to change service workers at the same time to make sure this is going to work?

> @@ -4666,6 +4665,7 @@ interface Request {
   readonly attribute RequestRedirect redirect;
   readonly attribute DOMString integrity;
   readonly attribute boolean keepalive;
+  readonly attribute AbortSignal? signal;

You haven't defined this attribute in prose.

> @@ -4683,6 +4683,7 @@ dictionary RequestInit {
   DOMString integrity;
   boolean keepalive;
   any window; // can only be set to null
+  AbortSignal signal;

Please move this one up. So it stays aligned with keepalive.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/523#pullrequestreview-38938037