- From: Brett Zamir <notifications@github.com>
- Date: Fri, 12 May 2017 03:24:56 -0700
- To: w3c/IndexedDB <IndexedDB@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 12 May 2017 10:25:30 UTC
I think this PR covers it well... However, besides if you wanted to add that invisible step to unset the done flag for successful transactions, there is the case also of `result` always needing to return `undefined` (per the `result` getter) when there is an error, so I don't know if you wanted to make that explicit for `open` and `deleteDatabase`. For example, for the following in the steps to open a database, "If connection was closed, create and return a newly created "AbortError" DOMException and abort these steps.", this isn't followed by setting the `result` to `undefined` (as now is the case with your PR if the steps to abort are triggered). And perhaps this could also occur with other errors of the database (like `UnknownError`) that didn't cause an abort. I think mention of setting the request result to `undefined` could be added close to the end of `open()` and `deleteDatabase()` when the request's `error` properties are set. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/IndexedDB/pull/202#issuecomment-301041549
Received on Friday, 12 May 2017 10:25:30 UTC