Re: [w3c/manifest] Use UTF-8 decode when obtaining a manifest (#570)

marcoscaceres commented on this pull request.

Few things we missed...

> @@ -1130,11 +1130,14 @@ <h3 id="navigation-scope-security-considerations">
           <li>If <var>response</var> is a <a>network error</a>, terminate this
           algorithm.
           </li>
+          <li>Let <var>text</var> be the result of <a>UTF-8 decoding</a> <var>
+            response</var>'s <a href=
+            "https://fetch.spec.whatwg.org/#concept-request-body">body</a>.

please avoid putting absolute URLs into the spec. Use:
```
<a data-cite="fetch#concept-request-body">body</a>
```

instead. 

> @@ -3732,6 +3735,16 @@ <h3 id="applying">
           split a string on spaces</dfn></a>
         </li>
       </ul>
+      <p>
+        The following are defined in [[!ENCODING]]:
+      </p>
+      <ul>
+        <li>
+          <a href=


And here, just do:
```
<dfn data-cite="encoding#utf-8-decode">UTF-8 decode</dfn>
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/570#pullrequestreview-35936650

Received on Wednesday, 3 May 2017 07:34:09 UTC