Re: [whatwg/fetch] Queue "process request body" tasks during request body transmission (#532)

annevk commented on this pull request.

Pretty close, one more nit.

>   <li>
-  <p>Let <var>read</var> be the result of <a lt="read a chunk" for=ReadableStream>reading a
-  chunk</a> from <var>body</var>'s <a for=body>stream</a>.
+  <p>Run these steps repeatedly, <a>in parallel</a>

I'd make this "In parallel, while true:" to make it clear you go in parallel once and then keep iterating.

>  
-   <li><p>When <var>read</var> is fulfilled with a value that matches with neither of the
-   above patterns, or <var>read</var> is rejected, <a lt=terminated for=fetch>terminate</a> the
-   ongoing fetch with reason <i>fatal</i>.
-  </ul>
+   <li><p>Otherwise, <a lt=terminated for=fetch>terminate</a> the ongoing fetch with reason
+   <i>fatal</i> and abort these steps.

One day we should make it clearer what the "ongoing fetch" is, but this was an existing bug so this is fine.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/532#pullrequestreview-35731921

Received on Tuesday, 2 May 2017 09:33:08 UTC