Re: [whatwg/fetch] Queue "process request body" tasks during request body transmission (#532)

annevk requested changes on this pull request.

This looks a lot better, but there's still some missing parameters to the algorithms as far as I can tell.

>  
-   <li><p>When <var>read</var> is fulfilled with a value that matches with neither of the
-   above patterns, or <var>read</var> is rejected, <a lt=terminated for=fetch>terminate</a> the
-   ongoing fetch with reason <i>fatal</i>.
-  </ul>
+ <li><p>If <var>p</var> is fulfilled with a value that matches with neither of the above patterns,
+ or <var>read</var> is rejected, <a lt=terminated for=fetch>terminate</a> the ongoing fetch with

"or read is rejected" isn't needed here, right? That already follows from p being fulfilled with a "wrong" value.

>  
  <li>
-  <p>Let <var>read</var> be the result of <a lt="read a chunk" for=ReadableStream>reading a
-  chunk</a> from <var>body</var>'s <a for=body>stream</a>.
+  <p>If <var>p</var> is fulfilled with an object whose <code>done</code> property is false
+  and whose <code>value</code> property is a <code>Uint8Array</code> object, run these steps:

then run*

> @@ -1170,45 +1170,56 @@ or "<code>worker</code>".
 
 <hr>
 
-<p>To <dfn export for=request id=concept-request-transmit-body>transmit body</dfn> for a
-<a for=/>request</a> <var>request</var>, run these steps:
+<p>To <dfn export for=request id=concept-request-transmit-body-chunk>transmit a chunk</dfn> for a
+promise <var>p</var>, run these steps <a>in parallel</a>:

It seems you still need to pass request or something as an argument here, since otherwise what do you end up doing the recursion on? _body_ below appears out of nowhere.

> @@ -1170,45 +1170,56 @@ or "<code>worker</code>".
 
 <hr>
 
-<p>To <dfn export for=request id=concept-request-transmit-body>transmit body</dfn> for a
-<a for=/>request</a> <var>request</var>, run these steps:
+<p>To <dfn export for=request id=concept-request-transmit-body-chunk>transmit a chunk</dfn> for a
+promise <var>p</var>, run these steps <a>in parallel</a>:

The original name "transmit body" might still be good therefore too. It just takes a promise as additional argument.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/532#pullrequestreview-35723638