Re: [heycam/webidl] Clarify and add examples for "extended attributes associated with" (#355)

tobie approved this pull request.

LGTM minus nits.

>          <emu-nt><a href="#prod-ExtendedAttributeList">ExtendedAttributeList</a></emu-nt> that are
         [=applicable to types=].
+
+        <div class="example">
+            <pre class="idl">
+                interface I {
+                    void f([XAttr] long attrib);
+                };
+            </pre>
+
+            but only if [<code>XAttr</code>] is [=applicable to types=]; otherwise

The lowercase "but" here is a bit weird. Maybe uppercase it or give a tad more context.

>          <emu-nt><a href="#prod-ExtendedAttributeList">ExtendedAttributeList</a></emu-nt> that are
         [=applicable to types=].
+
+        <div class="example">
+            <pre class="idl">
+                dictionary D {
+                    [XAttr] long member;
+                };
+            </pre>
+
+            but only if [<code>XAttr</code>] is [=applicable to types=]; otherwise

Same comment as above.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/355#pullrequestreview-35719253

Received on Tuesday, 2 May 2017 08:21:53 UTC