- From: Domenic Denicola <notifications@github.com>
- Date: Tue, 28 Mar 2017 23:10:56 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 29 March 2017 06:11:32 UTC
domenic commented on this pull request. > @@ -4230,7 +4230,10 @@ promises returned by its <a lt="writable stream writer">writer</a>'s {{WritableS return new WritableStream({ start(controller) { - ws.onerror = () => controller.error(new Error("The WebSocket errored!")); + ws.onerror = () => { + controller.error(new Error("The WebSocket errored!")); + ws.onclose = null; So does this overall LGTY now? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/713#discussion_r108597471
Received on Wednesday, 29 March 2017 06:11:32 UTC