Re: [whatwg/dom] Editorial: address Bikeshed linking errors (#426)

Why it started failing is easy: your linking text is wrong, but it was only a little while ago that my code started correctly recognizing that it was wrong (due to the way widlparser worked).  In particular, `before(nodes)` is *not* a valid signature for the function; `before(...nodes)` is.  (That is, it *does not* take an argument named "nodes", it takes a *rest argument* named "nodes".)

However, I've got some somewhat-wrong auto-massager code that also does some somewhat-wrong fixup in some circumstances; in particular, if you have an autolink without an `lt`, and it's a functionish type, it'll set the `lt` to an argument-less signature automatically.  This is correct for CSS functions, which don't have overloads and often show up in autolinks with all sorts of nonsense for args (like `''repeat(3, 10px)''` in an example, which just wants to link to the `repeat()` function definition), but it's wrong for IDL methods in case there *are* overloads.  (The shorthands like `{{before(nodes)}}` *do* set the `lt` on the HTML they generate, so they don't hit the massager, thus them breaking.)

---

So, actions:

1. I need to fix the massager code to not fire on IDL methods; it'll cause confusing inconsistencies sometimes (like here).

2. You need to fix DOM to use the right signature, with `...nodes` as the arg.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/426#issuecomment-289909302

Received on Tuesday, 28 March 2017 21:24:59 UTC