- From: Adam Rice <notifications@github.com>
- Date: Tue, 28 Mar 2017 04:32:22 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 28 March 2017 11:33:40 UTC
ricea commented on this pull request. > }); + + function closeWS(code, reasonString) { + return new Promise((resolve, reject) => { + ws.onclose = e => { The onerror event will fire redundantly. I think it is okay to ignore it completely, so just unsetting the event handler it should work. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/713#pullrequestreview-29423365
Received on Tuesday, 28 March 2017 11:33:40 UTC