Re: [w3c/manifest] Add support for adaptive icons (#563)

marcoscaceres requested changes on this pull request.

This is interesting. Has there been support from Google or Samsung about supporting this? 

> @@ -1799,6 +1824,14 @@ <h3 id="applying">
           next-most-appropriate icon as determined by examining the <a>image
           object's</a> members.
         </p>
+        <p class="note">
+          In order to use <a>adaptive icons</a>, you define the <code>foreground</code>

nit: `<a>foreground</a>` and same for background. 

> @@ -1799,6 +1824,14 @@ <h3 id="applying">
           next-most-appropriate icon as determined by examining the <a>image
           object's</a> members.
         </p>
+        <p class="note">
+          In order to use <a>adaptive icons</a>, you define the <code>foreground</code>
+          and <code>background</code> properties of <a>image objects</a>. These
+          are special properties only intented for icons and are thus ignored for
+          the <a><code>screenshots</code> member</a>.
+          A <code>src</code> can be added in order as a fallback for vendors which

"can be added in order as a fallback" doesn't read well. 

>  </pre>
         </div>
+        <div class="example">
+          <p>
+            In the following example, the developer is defining <a>adaptive icons</a>
+            with a fallback for UA not supporting that.
+          </p>
+          <pre class="">

class="json" (syntax highlighter will pick that up)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/563#pullrequestreview-29345264