Re: [whatwg/streams] Refactor writable stream erroring to be centralized (#705)

ricea commented on this pull request.



> +  1. Let _startResult_ be ? InvokeOrNoop(*this*.[[underlyingSink]], `"start"`, « *this* »).
+  1. Let _stream_ be *this*.[[controlledWritableStream]].
+  1. Let _startPromise_ be <a>a promise resolved with</a> _startResult_:
+    1. <a>Upon fulfillment</a>  of _startPromise_,
+      1. Set *this*.[[started]] to *true*.
+      1. If _stream_.[[state]] is `"errored"`, perform ! WritableStreamRejectAbortRequestIfPending(_stream_).
+      1. Otherwise, perform ! WritableStreamHandleAbortRequestIfPending(_stream_).
+      1. Perform ! WritableStreamDefaultControllerAdvanceQueueIfNeeded(*this*).
+    1. <a>Upon rejection</a> of _startPromise_ with reason _r_,
+      1. Assert: _stream_.[[state]] is `"writable"` or `"errored"`.
+      1. Perform ! WritableStreamDefaultControllerErrorIfNeeded(*this*, _r_).
+      1. Perform ! WritableStreamRejectAbortRequestIfPending(_stream_).
+</emu-alg>
+
+
+

Three blank lines is unusual in index.bs (I think this is the only place with 3).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/705#pullrequestreview-29156048

Received on Monday, 27 March 2017 11:12:41 UTC