Re: [whatwg/streams] Refactor writable stream erroring to be centralized (#705)

ricea commented on this pull request.



>    stream._state = 'errored';
   stream._storedError = error;
 
-  WritableStreamRejectPromisesInReactionToError(stream);
+  // TODO: layering violation?
+  ResetQueue(stream._writableStreamController);

It will probably lead to some extra churn when we add a ByteController, but as you say, we already have this issue in other places and in this case it's probably an easy fix (call stream.[[writableStreamController]].[[ResetQueue]] virtual method or similar).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/705#discussion_r107870900

Received on Friday, 24 March 2017 10:15:55 UTC