[whatwg/streams] Do not assume a BYOB reader when fulfilling a BYOB request (#698)

In particular, when autoAllocateChunkSize is in play, there may be a default reader instead. Fixes #686.

/cc @rombel. Let us know if you'd prefer a full name or similar in the acknowledgments!

@tyoshino I'm curious if this is the best solution. At first I tried to move the code into ReadableStreamClose, since ReadableStreamError has a branch on reader type and I thought ReadableStreamClose should be symmetric. But that caused failing tests, as I believe we want to keep the byobRequest around even if the stream gets closed. So this version seemed OK-ish.
You can view, comment on, or merge this pull request online at:

  https://github.com/whatwg/streams/pull/698

-- Commit Summary --

  * Do not assume a BYOB reader when fulfilling a BYOB request

-- File Changes --

    M index.bs (8)
    M reference-implementation/lib/readable-stream.js (14)

-- Patch Links --

https://github.com/whatwg/streams/pull/698.patch
https://github.com/whatwg/streams/pull/698.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/698

Received on Thursday, 16 March 2017 23:23:31 UTC