- From: Domenic Denicola <notifications@github.com>
- Date: Thu, 16 Mar 2017 15:01:36 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 16 March 2017 22:02:09 UTC
domenic approved this pull request. Code changes LGTM. > @@ -300,11 +300,7 @@ function WritableStreamFinishInFlightClose(stream) { } function WritableStreamFinishInFlightCloseInErroredState(stream) { I would be OK with inlining WritableStreamFinishInFlightWriteInErroredState and WritableStreamFinishInFlightCloseInErroredState now that they are two-liners and each called twice. Up to you though, I guess they are reasonably semantic operations that can stand on their own. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/688#pullrequestreview-27471001
Received on Thursday, 16 March 2017 22:02:09 UTC