Re: [whatwg/streams] Factor out condition to check pending operation (#672) from Domenic Denicola on 2017-03-09 (public-webapps-github@w3.org from March 2017)

From: Domenic Denicola <notifications@github.com>
Date: Thu, 09 Mar 2017 11:17:52 -0800
To: whatwg/streams <streams@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <whatwg/streams/pull/672/c285451376@github.com>

OK, the spec and reference implementation changes LGTM!

Are we sure that the only normative change here worth testing is the additional test in https://github.com/w3c/web-platform-tests/pull/5101 ? It seems like the three first bullets in https://github.com/whatwg/streams/pull/672#issuecomment-275343563 should each get a test.

Also, if this is really solving #632, then shouldn't the test changes in https://github.com/whatwg/streams/commit/33773df16229cdc99147b4d5ad29a0493fe6c41a#diff-4c7e8a1ce50d6c68c3d24df6461fcfd6 also be applied? (I am not sure though; it has been a while since that commit. But please take a look and check if possible.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/672#issuecomment-285451376

Received on Thursday, 9 March 2017 19:18:23 UTC