Re: [whatwg/streams] Factor out condition to check pending operation (#672)

tyoshino commented on this pull request.



>    stream._state = 'errored';
-  stream._storedError = new TypeError('Abort requested but closed successfully');
+  stream._storedError = error;
+
+  // TODO(tyoshino): No need to reject readyPromise?

Sorry. Never mind. It seems I was confused.

Abort()-ing a stream with in-flight close resets the readyPromise to a rejected promise, and it's final for the readyPromise as well as other places where we reject (or reset-to-rejected) the readyPromise. So, here we don't have to do anything for the readyPromise.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/672#discussion_r105103874

Received on Thursday, 9 March 2017 07:57:12 UTC