Re: [whatwg/streams] Factor out condition to check pending operation (#672)

tyoshino commented on this pull request.



>      1. Return.
   1. <a>Resolve</a> _stream_.[[pendingAbortRequest]] with *undefined*.
   1. Set _stream_.[[pendingAbortRequest]] to *undefined*.
+  1. Let _error_ to a new *TypeError* indicating that the stream was closed successfully after abort request.

I was struggling with this since
- it should represent the situation of the stream. not the abort operation
- it should tell what kind of bad thing has happened and how it was bad for the stream

Since the stream has finished closing successfully, the only bad things we should talk about are:
- the fact that there was an attempt to abort the stream (which didn't take place eventually)
- that the pending abort has been resolved without running sink.abort().


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/672#discussion_r105082242