- From: Takeshi Yoshino <notifications@github.com>
- Date: Tue, 07 Mar 2017 23:30:04 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 8 March 2017 07:30:36 UTC
tyoshino approved this pull request.
Overall approach looks good. Let me take a look again once I land the patch and you rebase this onto it. I hope that my refactoring help you this done.. :D
> @@ -713,10 +713,34 @@ class WritableStreamDefaultController {
Promise.resolve(startResult).then(
() => {
controller._started = true;
- WritableStreamDefaultControllerAdvanceQueueIfNeeded(controller);
+ const abortRequest = stream._pendingAbortRequest;
Yeah. They should be able to share the code.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/688#pullrequestreview-25711527
Received on Wednesday, 8 March 2017 07:30:36 UTC