Re: [whatwg/streams] Do not call sink abort() while sink start() is running (#688)

domenic approved this pull request.

LGTM with a potential refactoring avenue noted. In general as you've noted all the state machine management seems to have gotten a bit spread out, and it would be nice if there were some more principled way of achieving it, but sadly it sounds like the [[queue]] approach isn't it...

Please be sure to coordinate with @tyoshino's #672.

> @@ -713,10 +713,34 @@ class WritableStreamDefaultController {
     Promise.resolve(startResult).then(
       () => {
         controller._started = true;
-        WritableStreamDefaultControllerAdvanceQueueIfNeeded(controller);
+        const abortRequest = stream._pendingAbortRequest;

Is there any way to deduplicate this with the code in WritableStreamFinishPendingWrite ? They seem to serve rather similar purposes...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/688#pullrequestreview-25607033