Re: [whatwg/fetch] Allow range header to be set by APIs (#560)

annevk commented on this pull request.

Couple nits. I'll have more time to study the impact next week. The idea is that media APIs will set this flag?

> @@ -4219,9 +4251,6 @@ objects.</span>
 "<code>response</code>" or
 "<code>none</code>".
 
-<p class="note no-backref">"<code>immutable</code>" exists for service workers.
-[[!SW]]

Was this intentional?

> @@ -4240,6 +4269,17 @@ objects.</span>
  "<code>request</code>" and <var>name</var> is a <a>forbidden header name</a>,
  return.
 
+ <li><p>Otherwise, if <a for=Headers>guard</a> is "<code>request-no-cors</code>" and

Newline after `<li>` as it contains multiple children.

> @@ -4839,14 +4892,17 @@ constructor must run these steps:
 
    <li><p>Set <var>request</var>'s

Newline due to multiple children again.

> @@ -4839,14 +4892,17 @@ constructor must run these steps:
 
    <li><p>Set <var>request</var>'s
    <a for=request>referrer policy</a> to the empty string.
+   <p class=note>This is done to ensure that when a service worker "redirects" a request, .e.g.,

No dot before e.g.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/560#pullrequestreview-47216505

Received on Thursday, 29 June 2017 18:46:58 UTC