Re: [whatwg/url] Normalize port after updating scheme (#328)

GPHemsley commented on this pull request.



> @@ -1400,6 +1400,9 @@ string <var>input</var>, optionally with a <a>base URL</a> <var>base</var>, opti
 
        <li><p>Set <var>url</var>'s <a for=url>scheme</a> to <var>buffer</var>.
 
+       <li><p>If <var>url</var>'s <a for=url>port</a> is <var>url</var>'s <a for=url>scheme</a>'s
+       <a>default port</a>, then set <var>url</var>'s <a for=url>port</a> to null.

Ah, yes, I think I agree with this.

And while we're in the area, is there a reason resetting _buffer_ (3) is necessary before returning from a state override (4)?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/328#discussion_r124693649