- From: Domenic Denicola <notifications@github.com>
- Date: Fri, 23 Jun 2017 13:53:56 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 23 June 2017 20:54:28 UTC
Closes #208. Chrome is tentatively interested in this, although the first step is getting a spec and tests up for review. Would love to hear if other implementers are interested--- @smaug----, @cdumez, @travisleithead? I decided to go with an overload instead of a new method, so we can leave new method names for something potentially nicer like `on`/`off`. Overloading for this pattern is pretty common, e.g. it is what jQuery does. And introducing two similar-but-different method names like `removeEventListener` + `deleteEventListener` seemed like a bad idea. I also added an overload `removeEventListener(type, { group })` which is not really necessary. We could get rid of that if we don't like it. But it fell out naturally. This also preserves what I'm pretty sure is a bug, per #468, but at least it centralizes the probably-buggy check. You can view, comment on, or merge this pull request online at: https://github.com/whatwg/dom/pull/469 -- Commit Summary -- * Allow removing event listeners by group -- File Changes -- M dom.bs (156) -- Patch Links -- https://github.com/whatwg/dom/pull/469.patch https://github.com/whatwg/dom/pull/469.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/469
Received on Friday, 23 June 2017 20:54:28 UTC