Re: [w3c/push-api] Migrate the serializer to a toJSON method. (#267)

domenic commented on this pull request.

Agreed mostly looks good, although I'm not sure about this underlying value vs. serialized value business.

>          </li>
-        <li>Add an entry to <var>map</var> whose key name is <code>endpoint</code> and whose value
-        is the result of converting the <code>endpoint</code> attribute to a serialized value. The
+        <li>Set the <code>endpoint</code> property of <var>json</var> to the result of converting
+        the <a data-link-for="PushSubscription">endpoint</a> attribute to a serialized value. The
         <a>user agent</a> MUST use a serialization method that does not contain input-dependent
         branchs (that is, one that is constant time). Note that a URL - as ASCII text - will not

Preexisting text comment: URLs are not in the general case ASCII...

>        </ol>
+
+      <p>
+        A <dfn>PushSubscriptionJSON</dfn> dictionary represents the <a>JSON type</a> of a

Hmm I wonder why "JSON type" is showing up as code font in the output. It shouldn't, ideally.

>        </ol>
+
+      <p>
+        A <dfn>PushSubscriptionJSON</dfn> dictionary represents the <a>JSON type</a> of a
+        <a>PushSubscription</a> that can be converted into a JSON string.
+      </p>
+      <p>
+        The <dfn data-dfn-for="PushSubscriptionJSON">endpoint</dfn> contains the serialized value of

In this case it seems like there's actually a serialization process going on here, which is left up to the UA in some way. I.e. "The user agent MUST use a serialization method that does not contain input-dependent branchs (that is, one that is constant time)". I'm not sure what's really going on here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/267#pullrequestreview-45773258