Re: [w3c/push-api] Migrate the serializer to a toJSON method. (#267)

beverloo commented on this pull request.



> @@ -896,7 +898,14 @@
           [SameObject] readonly attribute PushSubscriptionOptions options;
           ArrayBuffer? getKey(PushEncryptionKeyName name);
           Promise<boolean> unsubscribe();
-          serializer;
+
+          PushSubscriptionJSON toJSON();
+        };
+
+        dictionary PushSubscriptionJSON {
+          USVString endpoint;
+          DOMTimeStamp? expirationTime;
+          record keys;

Ah yeah, I forgot to follow up on that - ReSpec seems to choke on `record<K, V>` syntax for some reason. The key should be a `DOMString` since it's one of the `PushEncryptionKeyName` values, and enum values are defined to be `DOMString`s.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/267#discussion_r123553949