Re: [w3c/manifest] Changed to allow site-triggered prompt without defaulting to automatic prompt (#584)

marcoscaceres requested changes on this pull request.

🎉 Just a couple of little things. Looking good. 

>            <dfn>automated install prompt</dfn>: that is, a <abbr>UI</abbr> that
           the user agent presents to the user when, for instance, there are
           sufficient <a>installability signals</a> to warrant
           <a>installation</a> of the web application.
-        </p>
+          </li>
+          <li>The <a>installation process</a> can occur through a
+          <dfn>site-triggered install prompt</dfn>: the site can
+          programmatically request that the user agent present an install
+          prompt to the user. The availability of this feature may be

s/The availability of this feature may be/The user agent MAY restrict the availability of this feature/

>          <p>
           Prior to presenting an <a>automated install prompt</a>, a user agent
-          MUST run the <a>steps to notify before an automated install
-          prompt</a>.
+          MUST run the <a>steps to notify that an install prompt is
+          available</a>, to give the site the opportunity to suppress the

I wonder if we should say, instead of "to give the site the opportunity to suppress the install prompt" something like "prevent the default action (which is to install the application)". That would maybe align better with `. preventDefault()` 

>          <p>
           Prior to presenting an <a>automated install prompt</a>, a user agent
-          MUST run the <a>steps to notify before an automated install
-          prompt</a>.
+          MUST run the <a>steps to notify that an install prompt is
+          available</a>, to give the site the opportunity to suppress the
+          install prompt. Alternatively, the user agent may run the <a>steps to

s/may/MAY

> @@ -531,6 +545,13 @@ <h3 id="installation-sec">
         <h3>
           <code>BeforeInstallPromptEvent</code> Interface
         </h3>
+        <div class="note">
+          The <code>beforeinstallprompt</code> event is somewhat misnamed, as
+          it does not necessarily signal that an <a>automated install
+          prompt</a> will follow (depending on the user agent, it may just be

s/it may just/it can just
or "it might just"
(avoid RFC2119 keywords in notes... even in lowercase)

> @@ -634,10 +658,10 @@ <h3 id="installation-sec">
           </h4>
           <p>
             This example shows how one might prevent an automated install
-            prompt from showing until the user clicks a button to install the
-            app. In this way, the site can leave installation at the user's
-            discretion (rather than prompting at an arbitrary time), whilst
-            still providing a prominent UI to do so.
+            prompt from showing until the user clicks a button to show a
+            site-triggered install prompt. In this way, the site can leave

nit:  link back to def `<a>site-triggered install prompt</a>`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/584#pullrequestreview-42527529