- From: Marcos Cáceres <notifications@github.com>
- Date: Mon, 05 Jun 2017 01:51:09 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/manifest/pull/567/review/41998159@github.com>
marcoscaceres requested changes on this pull request. Almost there! Just a couple of little nits. Text is looking good tho. > @@ -2891,6 +2896,66 @@ <h3 id="applying"> </ol> </section> </section> + <section> This section should be part of "8. Manifest and its members". Not it's own section. > @@ -2891,6 +2896,66 @@ <h3 id="applying"> </ol> </section> </section> + <section> (sorry I mean, a sub-section of "8. Manifest and its members") > + <a>[[\GetOwnProperty]]</a> internal method of <var>manifest</var> + with argument "<code>iarc_rating_id</code>". + </li> + <li>If <a>Type</a>(<var>value</var>) is not "string": + <ol> + <li>If <a>Type</a>(<var>value</var>) is not "undefined", <a>issue + a developer warning</a> that the type is not supported. + </li> + <li>Return <code>undefined</code>. + </li> + </ol> + </li> + <li>Otherwise, <a>Trim</a>(<var>value</var>) and return the result. + </li> + </ol> + <section class="informative"> Probably just change this to a `div` and drop the `class=`. > + <code>iarc_rating_id</code> member. + </p> + <pre class="example json" title="very simple manifest"> + { + "name": "Donate App", + "description": "This app helps you donate to worthy causes.", + "iarc_rating_id": "e84b072d-71b3-4d3e-86ae-31a8ce4e53b7", + "icons": [{ + "src": "images/icon.png", + "sizes": "192x192" + }] + } + </pre> + </section> + + <p> this should have a `class="note"` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/567#pullrequestreview-41998159
Received on Monday, 5 June 2017 08:51:42 UTC