- From: Adam Rice <notifications@github.com>
- Date: Thu, 01 Jun 2017 20:35:52 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 2 June 2017 03:36:28 UTC
Text changes roughly lgtm. I'm not sure about the name "signal" for the option. I'm asking myself "would I remember that?" and I don't know the answer. Generally the AbortController / AbortSignal design feels like it has a lot of cognitive overhead but I haven't come up with anything better. Compared to that, having two slightly different concepts called "abort" doesn't bother me. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/744#issuecomment-305680660
Received on Friday, 2 June 2017 03:36:28 UTC