Re: [whatwg/streams] Throw if undefined streams are passed to pipeThrough (#759)

domenic commented on this pull request.



> @@ -568,6 +568,8 @@ ReadableStream(<var>underlyingSource</var> = {}, { <var>size</var>, <var>highWat
 </div>
 
 <emu-alg>
+  1. If _writable_ is *undefined* or _readable_ is *undefined*, throw a *TypeError* exception indicating that undefined
+     values are not permitted.

_readable_ does not exist (use **this**). But that part is redundant with the next line, which will throw anyway. Implementations are free to do an identity check against undefined and throw a different TypeError if they want, since that's unobservable.

Will fix and merge.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/759#pullrequestreview-53280365

Received on Monday, 31 July 2017 17:29:30 UTC