- From: Tobie Langel <notifications@github.com>
- Date: Thu, 27 Jul 2017 11:43:52 +0000 (UTC)
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 27 July 2017 11:44:16 UTC
tobie commented on this pull request. > 1. Let |i| be [=!=] [=ToUint32=](|P|). 1. Let |s| be [=!=] [=ToString=](|i|). - 1. If |s| ≠ |P| or |i| = 2<sup>32</sup> − 1, then return <emu-val>false</emu-val>. - 1. Return <emu-val>true</emu-val>. + 1. If |s| is not equal to |P| or |i| = 2<sup>32</sup> − 1, then return false. Figured keeping "=" sort of made sense given these were ints, but then they're not abstract math values but actual ES values, so maybe "is" or "is equal to" are more appropriate. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/heycam/webidl/pull/386#discussion_r129819055
Received on Thursday, 27 July 2017 11:44:16 UTC