- From: raymeskhoury <notifications@github.com>
- Date: Wed, 05 Jul 2017 21:18:05 -0700
- To: w3c/permissions <permissions@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/permissions/pull/151/review/48231717@github.com>
raymeskhoury commented on this pull request. > + <li>If |permissionDesc| is not a JSON object, return <a>error</a> with + <a>error code</a> <a>invalid argument</a>.</li> + <li>Let |rootDesc| be the object |permissionDesc| refers to, <a>converted + to an IDL value</a> of type {{PermissionDescriptor}}. If this throws an + exception, return <a>error</a> with <a>error code</a> <a>invalid + argument</a>.</li> + <li>Let |typedDescriptor| be the object |permissionDesc| refers to, + <a>converted to an IDL value</a> of + <code>|rootDesc|.{{PermissionDescriptor/name}}</code>'s <a>permission + descriptor type</a>. If this throws an exception, return <a>error</a> + with <a>error code</a> <a>invalid argument</a>.</li> + <li>Let |settings| be the <a>current settings object</a>.</li> + <li>If |settings| is a <a>non-secure context</a> and + <code>|rootDesc|.{{PermissionDescriptor/name}}</code> isn't <a>allowed in + non-secure contexts</a>, return <a>error</a> with <a>error code</a> + <a>invalid argument</a>.</li> Yeah - I was just thinking of checks that might be added in the future. It's not a huge deal, just something to keep in mind. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/permissions/pull/151#discussion_r125808448
Received on Thursday, 6 July 2017 04:19:02 UTC