- From: Philip Jägenstedt <notifications@github.com>
- Date: Wed, 25 Jan 2017 07:28:59 -0800
- To: w3c/uievents <uievents@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 25 January 2017 15:29:30 UTC
The Dojo code is: ```JavaScript has.add("events-keypress-typed", function(){ // keypresses should only occur a printable character is hit var testKeyEvent = {charCode: 0}; try{ testKeyEvent = document.createEvent("KeyboardEvent"); (testKeyEvent.initKeyboardEvent || testKeyEvent.initKeyEvent).call(testKeyEvent, "keypress", true, true, null, false, false, false, false, 9, 3); }catch(e){} return testKeyEvent.charCode == 0 && !has("opera"); }); ``` Given that exceptions are caught, seems like just removing both `initKeyboardEvent` and `initKeyEvent` should still return in returning true here. If Dojo is the main user of `initKeyboardEvent`, then it may be necessary to do an exhaustive analysis of httparchive to see if it's obscuring other usages that would break in a bad way. If it and `initKeyEvent` can be removed with little risk that's great, but since we're not getting rid of all `init*Event` methods it'd also be fine to find some compatible intersection and call it a day. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/uievents/issues/112#issuecomment-275138399
Received on Wednesday, 25 January 2017 15:29:30 UTC