Re: [heycam/webidl] Update attribute setter/getters in various ways (#217)

tobie commented on this pull request.



> @@ -1377,6 +1377,10 @@ ignored or an exception is thrown.
     };
 </pre>
 
+The type of an attribute that is not [=read only=] must not be a [=promise type=]. Additionally,
+the type of an attribute with any of the [=extended attributes=] [{{LenientThis}}],
+[{{PutForwards}}], [{{Replaceable}}], or [{{SameObject}}] must not be a [=promise type=].

I think the below means the same thing and is clearer:

```
Attributes whose type is [=promise type|promise=] must be [=read only=].
Additionally, they cannot have any of the [=extended attributes=]
[{{LenientThis}}], [{{PutForwards}}], [{{Replaceable}}], or [{{SameObject}}].
```

> -            1.  Set |idlValue| to be the result of performing the actions listed in the description of the attribute that occur when getting
-                (or those listed in the description of the inherited attribute, if this attribute is declared to
-                [=inherit its getter=]),
-                with |O| as the object.
-        1.  Otherwise, the attribute is a [=static attribute=].
-            Set |idlValue| to be the result of performing the actions listed in the description of the attribute that occur when getting.
-        1.  Let |V| be the result of [=converted to an ECMAScript value|converting=]
-            |idlValue| to an ECMAScript value.
-        1.  Return |V|.
-    </div>
+    *   |G| is the [=attribute getter=] created given the attribute, the interface (or the interface
+        it's being mixed in to, if the interface is actually a mixin), and the [=relevant Realm=] of
+        the object that is the location of the property; and
+    *   |S| is the [=attribute setter=] created given the attribute, the interface (or the interface
+        it's being mixed in to, if the interface is actually a mixin), and the [=relevant Realm=] of
+        the object that is the location of the property.

I'm aware this is purposefully copied from the text in the operations binding, but: s/the object that is the location of the property/the object that contains the property/ would read better.

Maybe change it everywhere? Or not at all for now also works. :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/217#pullrequestreview-17398386