Re: [whatwg/url] Add non-special-URL hosts (#185)

domenic requested changes on this pull request.

Still not working unfortunately. The restriction on line 1947 to not append buffer to the path appears to be overzealous. E.g.

```
 11) Web platform tests parsing </i> against <sc://ho/pa>:

      AssertionError: href
      + expected - actual

      -sc://ho
      +sc://ho/i
```

(As usual, expected = from web platform tests; actual = jsdom/whatwg-url with this change)

It appears from some stepping through the code that that line is always reached when c is EOF.

> @@ -1195,6 +1223,38 @@ different document encoding. Using the <a>UTF-8</a> encoding everywhere solves t
 
 <hr>
 
+<p>The <dfn export id=concept-url-host-parser>URL-host parser</dfn> takes a string <var>input</var>
+and a boolean <var>isSpecial</var>, and then runs these steps:</p>
+
+<ol>
+ <li><p>If <var>isSpecial</var> is true, then return the result of
+ <a lt="host parser">host parsing</a> <var>input</var>.
+
+ <li><p>Let <var>output</var> be the empty string.

This step can move below the next one.

> @@ -2096,9 +2173,10 @@ then runs these steps:
  <li><p>If <var>url</var>'s <a for=url>cannot-be-a-base-URL flag</a> is set, append the first string
  in <var>url</var>'s <a for=url>path</a> to <var>output</var>.
 
- <li><p>Otherwise, append "<code>/</code>", followed by the strings in <var>url</var>'s
- <a for=url>path</a> (including empty strings), separated from each other by
- "<code>/</code>", to <var>output</var>.
+ <li><p>Otherwise, if <var>url</var>'s <a for=url>path</a>
+ <a for=list lt="is empty">is not empty</a>, then return append "<code>/</code>", followed by the

extra "return"

> @@ -1875,7 +1943,16 @@ string <var>input</var>, optionally with a <a>base URL</a> <var>base</var>, opti
 
           <p class=note>This is a (platform-independent) Windows drive letter quirk.
 
-         <li><p>Append <var>buffer</var> to <var>url</var>'s <a for=url>path</a>.
+         <li>
+          <p>If one of the following is true
+
+          <ul class=brief>
+           <li><p><var>url</var>'s <a for=url>path</a> is <a for=list lt="is empty">is not empty</a>

Double "is"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/185#pullrequestreview-17086666