- From: Anne van Kesteren <notifications@github.com>
- Date: Thu, 12 Jan 2017 03:39:28 -0800
- To: whatwg/xhr <xhr@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/xhr/pull/97/c272142369@github.com>
@tabatkins when I applied the following (does not fix all outstanding problems, I know) I got "`FATAL ERROR: Multiple local 'method' <dfn>s for 'FormData' have the same linking text 'append(name, blobValue, filename)'.`" What now? This seemed to be exactly what you suggested I do. ```diff diff --git a/xhr.bs b/xhr.bs index f847c7b..43b4cb4 100644 --- a/xhr.bs +++ b/xhr.bs @@ -1875,7 +1875,7 @@ typedef (File or USVString) FormDataEntryValue; Exposed=(Window,Worker)] interface FormData { void append(USVString name, USVString value); - void append(USVString name, Blob value, optional USVString filename); + void append(USVString name, Blob blobValue, optional USVString filename); void delete(USVString name); FormDataEntryValue? get(USVString name); sequence<FormDataEntryValue> getAll(USVString name); @@ -1946,10 +1946,14 @@ constructor must run these steps: </ol> <p>The -<dfn id=dom-formdata-append method for=FormData><code>append(<var>name</var>, <var>value</var>, <var>filename</var>)</code></dfn> -method, when invoked, must run these steps: +<dfn id=dom-formdata-append method for=FormData><code>append(<var>name</var>, <var>value</var>)</code></dfn> +and +<dfn id=dom-formdata-append-blob method for=FormData><code>append(<var>name</var>, <var>blobValue</var>, <var>filename</var>)</code></dfn> +methods, when invoked, must run these steps: <ol> + <li><p>Let <var>value</var> be <var>value</var> if given, and <var>blobValue</var> otherwise. + <li><p>Let <var>entry</var> be the result of <a lt="create an entry">creating an entry</a> with <var>name</var>, <var>value</var>, and <var>filename</var> if given. @@ -1957,6 +1961,9 @@ method, when invoked, must run these steps: <a>entries</a>. </ol> +<p class=note>The reason there is an argument named <var>value</var> as well as <var>blobValue</var> +is due to a limitation of the editing software used to write the XMLHttpRequest Standard. + <p>The <dfn id=dom-formdata-delete method for=FormData><code>delete(<var>name</var>)</code></dfn> method, when invoked, must remove all <a>entries</a> ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/xhr/pull/97#issuecomment-272142369
Received on Thursday, 12 January 2017 11:40:02 UTC