- From: Peter Beverloo <notifications@github.com>
- Date: Fri, 24 Feb 2017 11:10:41 -0800
- To: w3c/push-api <push-api@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/push-api/pull/238/review/23789086@github.com>
beverloo commented on this pull request. > @@ -907,13 +906,17 @@ <li>If the <a>push subscription</a> has already been <a>deactivated</a>, resolve <var>promise</var> with <code>false</code> and terminate these steps. </li> - <li>Make a request to the <a>push service</a> to <a>deactivate</a> the <a>push - subscription</a>. - </li> - <li>If it was not possible to access the <a>push service</a>, reject <var>promise</var> - with a "<a>NetworkError</a>" exception and terminate these steps. + <li>Run the following step in parallel: + <ol> + <li><a>Deactivate</a> the <a>push subscription</a>. The <a>user agent</a> MUST NOT + deliver any further <a>push messages</a> for the <a>push subscription</a>. + <p>If the <a>user agent</a> failed to request the <a>push service</a> to <a>deactivate</a> + the <a>push subscription</a>, for example because of network failures, it SHOULD retry + the request to the <a>push service</a> for a reasonable amount of time. Yes. My intention (with the "run the following step in parallel" sub-step) is that we hold the promise from resolving until the necessary work to stop messages from being delivered to the Service Worker has been completed, but not any longer than that (i.e. network activity to the push service). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/push-api/pull/238#discussion_r103010937
Received on Friday, 24 February 2017 19:12:04 UTC