- From: Jake Archibald <notifications@github.com>
 - Date: Fri, 24 Feb 2017 03:35:57 -0800
 - To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
 - Cc: Subscribed <subscribed@noreply.github.com>
 
Received on Friday, 24 February 2017 11:36:55 UTC
jakearchibald approved this pull request.
> @@ -1323,7 +1323,9 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe
 
         1. Upon [=upon fulfillment|fulfillment=] or [=upon rejection|rejection=] of |f|, [=queue a microtask=] to run these substeps:
             1. Decrement the [=ExtendableEvent/pending promises count=] by one.
-            1. Invoke [=Try Activate=] with the [=context object=]'s [=relevant global object=]'s associated [=ServiceWorkerGlobalScope/service worker=]'s [=containing service worker registration=].
+            1. Let |registration| be the [=context object=]'s [=relevant global object=]'s associated [=ServiceWorkerGlobalScope/service worker=]'s [=containing service worker registration=].
+            1. If |registration|'s [=uninstalling flag=] is set, invoke [=Try Clear Registration=] with |registration|.
Should this check to see if the registration is not null before checking the flag?
-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1079#pullrequestreview-23697067
Received on Friday, 24 February 2017 11:36:55 UTC