Re: [heycam/webidl] Cleanup DOMException. (#320)

domenic approved this pull request.

A few nits, LGTM overall.

>  listed in the [=error names table=] below.
 The table also indicates the {{DOMException}}'s integer code for that error name,
 if it has one.
 
 There are two types that can be used to refer to exception objects:
-{{Error!!interface}}, which encompasses all exceptions,
-and {{DOMException}} which includes just DOMException objects.
+{{DOMException}} and {{Error!!interface}},

Maybe ", where the latter encompasses..."

> @@ -7692,7 +7691,7 @@ that correspond to the union’s [=member types=].
 
 IDL {{Error!!interface}} values are represented
 by native ECMAScript <emu-val>Error</emu-val> objects and
-platform objects for {{DOMException|DOMExceptions}}.
+platform objects for {{DOMException}} objects.

"and by {{DOMException}} platform objects" perhaps

> @@ -7716,8 +7715,7 @@ platform objects for {{DOMException|DOMExceptions}}.
 
 <h4 id="es-DOMException">DOMException</h4>
 
-IDL {{DOMException}} values are represented
-by platform objects for {{DOMException|DOMExceptions}}.
+IDL {{DOMException}} values are represented by [=platform objects=].

Comparing this sentence to the rest of the ones in this section, it makes very little sense. I would just remove it. Or maaaybe replace it with "IDL {{DOMException}} values are represented by ECMAScript Object values" (cf. interfaces).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/320#pullrequestreview-23571831