Re: [heycam/webidl] Carry out math operations on real numbers, not IEEE 754. (#316)

domenic commented on this pull request.



> @@ -6789,7 +6798,8 @@ may return any value, which will be discarded.
     1.  Otherwise:
         1.  Let |lowerBound| be -2<sup>|bitLength| − 1</sup>.
         1.  Let |upperBound| be 2<sup>|bitLength| − 1</sup> − 1.
-    1.  Set |x| to [=?=] [=ToNumber=](|V|).
+    1.  Let |x| be [=?=] [=ToNumber=](|V|).
+    1.  If |x| is −0 or |x| is +0, then set |x| to 0.

Shouldn't this only apply if x is -0?

> @@ -6815,7 +6825,7 @@ may return any value, which will be discarded.
         1.  Round |x| to the nearest integer, choosing the even integer if it lies halfway between two,
             and choosing +0 rather than −0.
         1.  Return |x|.
-    1.  If |x| is <emu-val>NaN</emu-val>, +0, −0, +∞, or −∞,
+    1.  If |x| is <emu-val>NaN</emu-val>, +∞, or −∞,

Why remove the check for if x is +0?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/316#pullrequestreview-23286917