Re: [w3c/push-api] Connectivity is not required to unsubscribe a subscription (#238)

martinthomson commented on this pull request.



> @@ -907,13 +906,17 @@
         <li>If the <a>push subscription</a> has already been <a>deactivated</a>, resolve
         <var>promise</var> with <code>false</code> and terminate these steps.
         </li>
-        <li>Make a request to the <a>push service</a> to <a>deactivate</a> the <a>push
-        subscription</a>.
-        </li>
-        <li>If it was not possible to access the <a>push service</a>, reject <var>promise</var>
-        with a "<a>NetworkError</a>" exception and terminate these steps.
+        <li>Run the following step in parallel:
+          <ol>
+            <li><a>Deactivate</a> the <a>push subscription</a>. The <a>user agent</a> MUST NOT
+            deliver any further <a>push messages</a> for the <a>push subscription</a>.
+            <p>If the <a>user agent</a> failed to request the <a>push service</a> to <a>deactivate</a>
+            the <a>push subscription</a>, for example because of network failures, it SHOULD retry
+            the request to the <a>push service</a> for a reasonable amount of time.

Do we want to hold the resolution of the promise on this concluding, or are we really just doing this as a background task.  If this is a background task, then the browser could resolve the promise after whatever local steps it might need to take have been taken.  For instance, Firefox would remove entries from indexedDB, but then the network actions could happen in their own time.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/238#pullrequestreview-22680855