Re: [w3c/push-api] Restructure the `push` event (#237)

beverloo commented on this pull request.



> -          <li>Set the <code>data</code> attribute of the event to a new <a>PushMessageData</a>
-          instance with <code>bytes</code> set to <var>b</var>.
-          </li>
-        </ol>
+            </li>
+            <li>Set <var>b</var> to the result of <a data-lt="extract a byte sequence">extracting a
+            byte sequence</a> from the "<code>data</code>" member of <var>eventInitDict</var>.
+            </li>
+            <li>Set the <code>data</code> attribute of the event to a new <a>PushMessageData</a>
+            instance with <code>bytes</code> set to <var>b</var>.
+            </li>
+          </ol>
+          <p>
+            The <dfn>data</dfn> attribute contains the data included in the <a>push message</a> when
+            included and the <a>user agent</a> verified its authenticity. The value will be set to
+            <code>null</code> in all other cases.

^^^ This still is somewhat redundant (since `Receiving a Push Message` does the validation) and doesn't capture the case where a `PushEvent` is created from a `PushEventInit` structure. Would the following work for you?

> The \<dfn>data\</dfn> attribute contains the data associated with the \<a>push message\</a>. The value will be set to \<code>null\</code> when no data has been given.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/237#pullrequestreview-22567170

Received on Friday, 17 February 2017 18:59:29 UTC