- From: Takeshi Yoshino <notifications@github.com>
- Date: Wed, 15 Feb 2017 20:18:16 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 16 February 2017 04:18:48 UTC
tyoshino approved this pull request.
lgtm
> @@ -656,20 +650,26 @@ function WritableStreamDefaultWriterWrite(writer, chunk) {
assert(stream !== undefined);
+ const controller = stream._writableStreamController;
+
+ const chunkSize = WritableStreamDefaultControllerGetChunkSize(controller, chunk);
It's really unfortunate that we need to do this in the Writer's abstract op. Ideally, the detail of the operation should be hidden. But ok for now.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/680#pullrequestreview-22170708
Received on Thursday, 16 February 2017 04:18:48 UTC