Re: [w3c/IndexedDB] Fixes for 'steps for storing' (#146)

Realized I have a few more questions that may be somewhat interconnected if you want them here or before completing the PR:

1. Should the second step of "convert a value to a multiEntry key", namely:

> Otherwise, return the result of running the steps to convert a value to a key with argument input.

become:

> Otherwise, return the result of running the steps to convert a value to a key with argument input. Rethrow any exceptions.

...or is the rethrowing somehow assumed with "return"?

2. For "extract a key from a value using a key path", should the second step, namely:

> If r is failure, return failure.

be followed by:

> If r is invalid, return invalid.

(or an assertion if this is not possible as one might think could occur given that "evaluate a key path on a value" recurses back to these steps which can return "invalid")?

3. As with #2, should "evaluate a key path on a value", should step 1.3.1, namely:

> Let key be the result of recursively running the steps to extract a key from a value using a key path using item as keyPath and value as value.

...be followed by a condition about what to do if it is valid (or assertion that it should not be possible as one might expect given that "extract a key from a value using a key path" can return "invalid")

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/IndexedDB/pull/146#issuecomment-279923232

Received on Wednesday, 15 February 2017 05:50:48 UTC