[whatwg/url] Setting path to base's path seems wrong (#231)

When reviewing https://github.com/whatwg/url/pull/225 I noticed this, and I imagine it's widespread:

> Set url’s host to base’s host, **url’s path to base’s path**, and url’s query to base’s query.

A strict reading of this is that it sets url's path to the same list as base's path, so any future modifications to url's path get reflected in the base URL. That seems pretty bad. It should instead be a copy, right?


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/issues/231

Received on Friday, 3 February 2017 20:18:01 UTC