Re: [w3c/ServiceWorker] Make the promise settlement type of WindowClient.navigate() nullable (#1253) from Jungkee Song on 2017-12-21 (public-webapps-github@w3.org from December 2017)

From: Jungkee Song <notifications@github.com>
Date: Wed, 20 Dec 2017 19:16:13 -0800
To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <w3c/ServiceWorker/pull/1253/c353247348@github.com>

LGTM. Thanks @romandev!

We already have a test for it: https://github.com/wanderview/web-platform-tests/blob/master/service-workers/service-worker/windowclient-navigate.https.html#L49.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1253#issuecomment-353247348

Received on Thursday, 21 December 2017 03:16:39 UTC