Re: [whatwg/dom] Improving ergonomics of events with Observable (#544) from Gerard Sans on 2017-12-14 (public-webapps-github@w3.org from December 2017)

From: Gerard Sans <notifications@github.com>
Date: Thu, 14 Dec 2017 06:49:46 +0000 (UTC)
To: whatwg/dom <dom@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <whatwg/dom/issues/544/351624014@github.com>

Quick note for @appsforartists. Just want to point a common misunderstanding regarding `takeUntil` as you didn't add it to your code snippet. 

It doesn't only unsubscribe but also *completes* the source Observable. `takeUntil` will trigger the `complete` callback if present. I think is worth mentioning for accuracy.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/issues/544#issuecomment-351624014

Received on Thursday, 14 December 2017 06:50:15 UTC